Scaffolding #1916
Merged
Scaffolding #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+186
to
+189
| go func() { | ||
| ch <- am.ExportGenesis(ctx, cdc) | ||
| close(ch) | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
dssei
reviewed
Oct 31, 2024
x/evm/types/params.pb.go
Outdated
| @@ -104,53 +104,122 @@ func (m *Params) GetTargetGasUsedPerBlock() uint64 { | |||
| return 0 | |||
| } | |||
|
|
|||
| type ParamsPreV580 struct { | |||
There was a problem hiding this comment.
not sure why that is being generated. Seen this too, but dropped
dssei
reviewed
Oct 31, 2024
dssei
reviewed
Oct 31, 2024
dssei
reviewed
Oct 31, 2024
| DecryptableAvailableBalance string | ||
| } | ||
|
|
||
| func (m *Account) ToProto() *CtAccount { |
There was a problem hiding this comment.
For consistency, either my changes have to move to ToProto to non proto objects or this has method would move to CtAccount
There was a problem hiding this comment.
I changed this to a constructor in CtAccount instead - (NewCtAccount).
dssei
reviewed
Oct 31, 2024
mj850
added a commit
that referenced
this pull request
Dec 7, 2024
* scaffolding for new module * keeper scaffolding * scaffold with types * go sum * comments pt1 * comments * drop prev580
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Adds the basic scaffolding for the rest of the app
Testing performed to validate your change