Add NFT Marketplace Tests #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1829 +/- ##
==========================================
+ Coverage 60.99% 61.02% +0.03%
==========================================
Files 259 259
Lines 22824 22824
==========================================
+ Hits 13922 13929 +7
+ Misses 7917 7910 -7
Partials 985 985 |
besated
reviewed
Aug 23, 2024
| @@ -0,0 +1,48 @@ | |||
| # dApp Tests | |||
| @@ -20,5 +20,6 @@ npx hardhat compile | |||
| # Set the CONFIG environment variable | |||
| export DAPP_TEST_ENV=$1 | |||
|
|
|||
| npx hardhat test --network $1 uniswap/uniswapTest.js | |||
| npx hardhat test --network $1 steak/SteakTests.js | |||
| #npx hardhat test --network $1 uniswap/uniswapTest.js | |||
There was a problem hiding this comment.
is this supposed to be commented out? also maybe we can add another argument to specify which test to run - and if no argument is passed, it just runs all 3?
There was a problem hiding this comment.
Oops, forgot to add it back in when I was testing something - just updated to take in the argument so it's easier to run locally
besated
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Add NFT Marketplace tests to dapp tests
We test for:
Notably, since unassociated accounts cannot own pointer tokens, they are unable to buy tokens (fails while estimating gas). Should check if this is expected behavior?
Testing performed to validate your change
CI Pipeline additions