-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove serialize/deserialize for accesslist #1701
Open
codchen
wants to merge
6
commits into
main
Choose a base branch
from
optimize-accesslist
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1701 +/- ##
==========================================
- Coverage 60.87% 60.78% -0.10%
==========================================
Files 370 370
Lines 27436 27447 +11
==========================================
- Hits 16702 16683 -19
- Misses 9592 9622 +30
Partials 1142 1142
|
3d77fa8
to
7a64d32
Compare
f7a6231
to
9fdea2b
Compare
9fdea2b
to
26c91e6
Compare
yzang2019
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Because accessLists are only used within the lifespan of its transaction, there is no need to serialize/deserialize it as it won't be transmitted over wire nor written to disk. This would improve performance for transactions that make heavy usage of accesslists
Testing performed to validate your change
no behavioral change so existing unit tests should cover