[oracle] Add staleness indicator to exchange rate store #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codchen
reviewed
May 27, 2022
x/oracle/keeper/keeper.go
Outdated
| if denom == utils.MicroBaseDenom { | ||
| return sdk.OneDec(), nil | ||
| return sdk.OneDec(), sdk.ZeroInt(), nil |
There was a problem hiding this comment.
it might be easier for this to be set as the latest period-end block so that callers can handle base vs. non-base denom exchange rates consistently. Something like ctx.BlockHeight() / votePeriod * votePeriod. (would also make the eventual switch of base denom to sei easier)
codchen
approved these changes
May 27, 2022
codchen
approved these changes
May 27, 2022
philipsu522
approved these changes
May 31, 2022
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| ) | ||
|
|
||
| func TestMigrate2to3(t *testing.T) { |
There was a problem hiding this comment.
+1 - this is an awesome test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a work in progress, most of the business logic is complete though.