Add limit to filter logs #1558
Merged
Add limit to filter logs #1558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,6 +99,8 @@ var DefaultConfig = Config{ | |||
| MaxTxPoolTxs: 1000, | |||
| Slow: false, | |||
| DenyList: make([]string, 0), | |||
| MaxLogNoBlock: 10000, | |||
| MaxBlocksForLog: 2000, | |||
There was a problem hiding this comment.
do you think we should make this larger given we have such fast blocks? (is it disruptive to only be able to query ~11 minutes of logs?)
There was a problem hiding this comment.
i think the limit is applied "post-filter" so in most cases it would be able to cover much longer periods? For blanket filters that don't filter anything I think the recommendation from alchemy etc. is to use the subscribe endpoint instead which doesn't have such a limit
stevenlanders
approved these changes
Apr 17, 2024
udpatil
pushed a commit
that referenced
this pull request
Apr 18, 2024
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
We want to apply a limit for log-related queries similar to how Alchemy does for its endpoints:
Testing performed to validate your change
unit test