Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC transfer precompile #1459

Closed
wants to merge 16 commits into from
Closed

IBC transfer precompile #1459

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6f3c513
draft untested version
dssei Mar 19, 2024
300140c
adding test
dssei Mar 21, 2024
3e5b00f
draft self-review
dssei Mar 21, 2024
fab8312
bump the number of precompile
dssei Mar 21, 2024
4f845e0
goimports -ed
dssei Mar 21, 2024
86e8e2b
working happy path test
dssei Mar 22, 2024
06189c9
make transfer keeper pluggable
dssei Mar 22, 2024
5db906c
address review comments - part one
dssei Mar 22, 2024
3c4e47f
dynamic gas rework
dssei Mar 22, 2024
a2fd912
update test
dssei Mar 22, 2024
cbfc70c
validate calling contract
dssei Mar 22, 2024
cf9d1ca
add gas assertions
dssei Mar 22, 2024
8cd477e
add more tests/fixes
dssei Mar 23, 2024
ec484c1
goimports-ed
dssei Mar 23, 2024
e04fa37
change from evm receiver address to bech32 compatible address
dssei Mar 26, 2024
9a40d9b
goimports-ed
dssei Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bump the number of precompile
  • Loading branch information
@dssei
dssei committed Mar 21, 2024
commit fab8312e96761c004da0764440043b4c3fde8ae9
6 changes: 3 additions & 3 deletions precompiles/ibc/IBC.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;

address constant BANK_PRECOMPILE_ADDRESS = 0x0000000000000000000000000000000000001008;
address constant IBC_PRECOMPILE_ADDRESS = 0x0000000000000000000000000000000000001009;

IBC constant BANK_CONTRACT = IBC(
BANK_PRECOMPILE_ADDRESS
IBC constant IBC_CONTRACT = IBC(
IBC_PRECOMPILE_ADDRESS
);

interface IBC {
Expand Down
2 changes: 1 addition & 1 deletion precompiles/ibc/ibc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import (
"bytes"
"embed"
"errors"

Check failure on line 6 in precompiles/ibc/ibc.go

View workflow job for this annotation

GitHub Actions / lint 

File is not `goimports`-ed (goimports)
sdk "github.com/cosmos/cosmos-sdk/types"
clienttypes "github.com/cosmos/ibc-go/v3/modules/core/02-client/types"
"github.com/ethereum/go-ethereum/accounts/abi"
Expand All @@ -18,7 +18,7 @@
)

const (
IBCAddress = "0x0000000000000000000000000000000000001008"
IBCAddress = "0x0000000000000000000000000000000000001009"
)

var _ vm.PrecompiledContract = &Precompile{}
Expand Down Expand Up @@ -60,12 +60,12 @@
evmKeeper: evmKeeper,
}

for name, m := range newAbi.Methods {
switch name {
case TransferMethod:
p.TransferID = m.ID
}
}

return p, nil
}
Expand Down
Loading