-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EVM] univ2 loadtest #1423
[EVM] univ2 loadtest #1423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm
loadtest/main.go
Outdated
txClient.evmAddresses.UniV2Router = uniV2RouterAddress | ||
txClient.evmAddresses.UniV2Token1 = uniV2Token1Address | ||
txClient.evmAddresses.UniV2Token2 = uniV2Token2Address | ||
tx1 := txClient.GenerateToken1MintERC20Tx() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we call getTransactionReceipt
to verify these actually succeed?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## seiv2 #1423 +/- ##
==========================================
- Coverage 62.88% 62.86% -0.03%
==========================================
Files 350 350
Lines 23958 23958
==========================================
- Hits 15066 15061 -5
- Misses 8028 8031 +3
- Partials 864 866 +2 |
* checkpoint * add univ2 contracts + deploy_uinv2.sh * able to deploy uniswapv2 * Unifap -> Uniswap * univ2 set up * trying to do swaps * swaps work * swaps in both directions work * increase liquidity in pool * remove prints * revert changes to make loadtest work locally * add legacy to forge cmds * add print statement * debug * add UNIV2 msg type * turn off ensure tx success * comment out prints * print * print * cleanup * cleanup * print script output * debug * forge install + parallelize token mints and approvals * create intermediary univ2 swapper * cleanup + remove bindings for univ2 pair and router * cleanup * fix * cleanup * query wallet balance in script * appease linter
* checkpoint * add univ2 contracts + deploy_uinv2.sh * able to deploy uniswapv2 * Unifap -> Uniswap * univ2 set up * trying to do swaps * swaps work * swaps in both directions work * increase liquidity in pool * remove prints * revert changes to make loadtest work locally * add legacy to forge cmds * add print statement * debug * add UNIV2 msg type * turn off ensure tx success * comment out prints * print * print * cleanup * cleanup * print script output * debug * forge install + parallelize token mints and approvals * create intermediary univ2 swapper * cleanup + remove bindings for univ2 pair and router * cleanup * fix * cleanup * query wallet balance in script * appease linter
* checkpoint * add univ2 contracts + deploy_uinv2.sh * able to deploy uniswapv2 * Unifap -> Uniswap * univ2 set up * trying to do swaps * swaps work * swaps in both directions work * increase liquidity in pool * remove prints * revert changes to make loadtest work locally * add legacy to forge cmds * add print statement * debug * add UNIV2 msg type * turn off ensure tx success * comment out prints * print * print * cleanup * cleanup * print script output * debug * forge install + parallelize token mints and approvals * create intermediary univ2 swapper * cleanup + remove bindings for univ2 pair and router * cleanup * fix * cleanup * query wallet balance in script * appease linter
* checkpoint * add univ2 contracts + deploy_uinv2.sh * able to deploy uniswapv2 * Unifap -> Uniswap * univ2 set up * trying to do swaps * swaps work * swaps in both directions work * increase liquidity in pool * remove prints * revert changes to make loadtest work locally * add legacy to forge cmds * add print statement * debug * add UNIV2 msg type * turn off ensure tx success * comment out prints * print * print * cleanup * cleanup * print script output * debug * forge install + parallelize token mints and approvals * create intermediary univ2 swapper * cleanup + remove bindings for univ2 pair and router * cleanup * fix * cleanup * query wallet balance in script * appease linter
* checkpoint * add univ2 contracts + deploy_uinv2.sh * able to deploy uniswapv2 * Unifap -> Uniswap * univ2 set up * trying to do swaps * swaps work * swaps in both directions work * increase liquidity in pool * remove prints * revert changes to make loadtest work locally * add legacy to forge cmds * add print statement * debug * add UNIV2 msg type * turn off ensure tx success * comment out prints * print * print * cleanup * cleanup * print script output * debug * forge install + parallelize token mints and approvals * create intermediary univ2 swapper * cleanup + remove bindings for univ2 pair and router * cleanup * fix * cleanup * query wallet balance in script * appease linter
* checkpoint * add univ2 contracts + deploy_uinv2.sh * able to deploy uniswapv2 * Unifap -> Uniswap * univ2 set up * trying to do swaps * swaps work * swaps in both directions work * increase liquidity in pool * remove prints * revert changes to make loadtest work locally * add legacy to forge cmds * add print statement * debug * add UNIV2 msg type * turn off ensure tx success * comment out prints * print * print * cleanup * cleanup * print script output * debug * forge install + parallelize token mints and approvals * create intermediary univ2 swapper * cleanup + remove bindings for univ2 pair and router * cleanup * fix * cleanup * query wallet balance in script * appease linter
* checkpoint * add univ2 contracts + deploy_uinv2.sh * able to deploy uniswapv2 * Unifap -> Uniswap * univ2 set up * trying to do swaps * swaps work * swaps in both directions work * increase liquidity in pool * remove prints * revert changes to make loadtest work locally * add legacy to forge cmds * add print statement * debug * add UNIV2 msg type * turn off ensure tx success * comment out prints * print * print * cleanup * cleanup * print script output * debug * forge install + parallelize token mints and approvals * create intermediary univ2 swapper * cleanup + remove bindings for univ2 pair and router * cleanup * fix * cleanup * query wallet balance in script * appease linter
Describe your changes and provide context
complex contract interactions in loadtest using univ2.
Testing performed to validate your change
ran it on loadtest client.