Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CW721 wrapper for ERC721 #1264

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Add CW721 wrapper for ERC721 #1264

merged 2 commits into from
Jan 23, 2024

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Jan 22, 2024

Describe your changes and provide context

Add a CosmWasm wrapper following the CW721 spec over an underlying ERC721 contract. Note that since ERC721 doesn't have burn in its spec, the burn function on the CW wrapper will always return an error.

Testing performed to validate your change

local sei test
unit tests

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (7241f2c) 64.23% compared to head (acf08be) 63.93%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              evm    #1264      +/-   ##
==========================================
- Coverage   64.23%   63.93%   -0.30%     
==========================================
  Files         344      346       +2     
  Lines       22805    22987     +182     
==========================================
+ Hits        14648    14696      +48     
- Misses       7350     7472     +122     
- Partials      807      819      +12     
Files Coverage Δ
x/evm/keeper/evm.go 63.30% <50.00%> (ø)
x/evm/client/wasm/query.go 31.03% <35.89%> (ø)

... and 3 files with indirect coverage changes

@codchen codchen requested a review from philipsu522 January 22, 2024 08:17
Copy link
Contributor

@philipsu522 philipsu522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a unit test for end to end lifecycle of creating minting burning revoking...etc of an nft? could be a start task for someone else too

@codchen
Copy link
Collaborator Author

codchen commented Jan 23, 2024

@philipsu522 yeah that'd be quite a large test though (needs to instantiate an EVM contract, send EVM txs to mint tokens, instantiate a CW contract, send CW txs) so I'd include it in a dedicated PR

@codchen codchen merged commit 4ca5398 into evm Jan 23, 2024
37 of 38 checks passed
@codchen codchen deleted the cw721-evm branch January 23, 2024 08:14
udpatil pushed a commit that referenced this pull request Jan 31, 2024
* Add CW721 wrapper for ERC721

* tests
udpatil pushed a commit that referenced this pull request Feb 28, 2024
* Add CW721 wrapper for ERC721

* tests
udpatil pushed a commit that referenced this pull request Feb 28, 2024
* Add CW721 wrapper for ERC721

* tests
udpatil pushed a commit that referenced this pull request Feb 28, 2024
* Add CW721 wrapper for ERC721

* tests
udpatil pushed a commit that referenced this pull request Mar 4, 2024
* Add CW721 wrapper for ERC721

* tests
udpatil pushed a commit that referenced this pull request Mar 4, 2024
* Add CW721 wrapper for ERC721

* tests
udpatil pushed a commit that referenced this pull request Mar 11, 2024
* Add CW721 wrapper for ERC721

* tests
udpatil pushed a commit that referenced this pull request Mar 26, 2024
* Add CW721 wrapper for ERC721

* tests
udpatil pushed a commit that referenced this pull request Apr 17, 2024
* Add CW721 wrapper for ERC721

* tests
udpatil pushed a commit that referenced this pull request Apr 17, 2024
* Add CW721 wrapper for ERC721

* tests
udpatil pushed a commit that referenced this pull request Apr 17, 2024
* Add CW721 wrapper for ERC721

* tests
udpatil pushed a commit that referenced this pull request Apr 18, 2024
* Add CW721 wrapper for ERC721

* tests
udpatil pushed a commit that referenced this pull request Apr 19, 2024
* Add CW721 wrapper for ERC721

* tests
udpatil pushed a commit that referenced this pull request Apr 19, 2024
* Add CW721 wrapper for ERC721

* tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants