-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CW721 wrapper for ERC721 #1264
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## evm #1264 +/- ##
==========================================
- Coverage 64.23% 63.93% -0.30%
==========================================
Files 344 346 +2
Lines 22805 22987 +182
==========================================
+ Hits 14648 14696 +48
- Misses 7350 7472 +122
- Partials 807 819 +12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a unit test for end to end lifecycle of creating minting burning revoking...etc of an nft? could be a start task for someone else too
@philipsu522 yeah that'd be quite a large test though (needs to instantiate an EVM contract, send EVM txs to mint tokens, instantiate a CW contract, send CW txs) so I'd include it in a dedicated PR |
* Add CW721 wrapper for ERC721 * tests
* Add CW721 wrapper for ERC721 * tests
* Add CW721 wrapper for ERC721 * tests
* Add CW721 wrapper for ERC721 * tests
* Add CW721 wrapper for ERC721 * tests
* Add CW721 wrapper for ERC721 * tests
* Add CW721 wrapper for ERC721 * tests
* Add CW721 wrapper for ERC721 * tests
* Add CW721 wrapper for ERC721 * tests
* Add CW721 wrapper for ERC721 * tests
* Add CW721 wrapper for ERC721 * tests
* Add CW721 wrapper for ERC721 * tests
* Add CW721 wrapper for ERC721 * tests
* Add CW721 wrapper for ERC721 * tests
Describe your changes and provide context
Add a CosmWasm wrapper following the CW721 spec over an underlying ERC721 contract. Note that since ERC721 doesn't have
burn
in its spec, theburn
function on the CW wrapper will always return an error.Testing performed to validate your change
local sei test
unit tests