EVM ERC20 Template Contract #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## evm #1146 +/- ##
==========================================
+ Coverage 65.49% 65.53% +0.03%
==========================================
Files 328 328
Lines 21001 21001
==========================================
+ Hits 13754 13762 +8
+ Misses 6540 6533 -7
+ Partials 707 706 -1 |
codchen
reviewed
Nov 17, 2023
There was a problem hiding this comment.
overall looks good. We can test it on a local sei before merging:
- create a tokenfactory denom:
seid tx tokenfactory create-denom test - mint some tokens for an account:
seid tx tokenfactory mint - instantiate an ERC-20 contract for the denom
- send tokens from the minted account to another account via ERC-20
- verify the receiver received the tokens
contracts/src/Counter.sol
Outdated
| // SPDX-License-Identifier: UNLICENSED | ||
| pragma solidity ^0.8.13; | ||
|
|
||
| contract Counter { |
There was a problem hiding this comment.
do we need this counter contract?
| IBank public BankPrecompile; | ||
|
|
||
| constructor(string memory denom_) ERC20("", "") { | ||
| BankPrecompile = IBank(BANK_PRECOMPILE_ADDRESS); |
There was a problem hiding this comment.
just curious: how much space would it take to store BankPrecompile as a state? Is it just an address?
There was a problem hiding this comment.
yes it should just be an address.
| import {IBank} from "./precompiles/IBank.sol"; | ||
| import {console2} from "forge-std/Test.sol"; | ||
|
|
||
| contract NativeSeiTokensERC20 is ERC20 { |
There was a problem hiding this comment.
is ERC20 gives us the sending and approval functionalities i suppose?
There was a problem hiding this comment.
yes it is the syntax to do inheritance.
philipsu522
approved these changes
Nov 21, 2023
codchen
pushed a commit
that referenced
this pull request
Jan 5, 2024
* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix
codchen
pushed a commit
that referenced
this pull request
Jan 8, 2024
* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix
udpatil
pushed a commit
that referenced
this pull request
Jan 31, 2024
* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix
udpatil
pushed a commit
that referenced
this pull request
Feb 28, 2024
* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix
udpatil
pushed a commit
that referenced
this pull request
Feb 28, 2024
* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix
udpatil
pushed a commit
that referenced
this pull request
Feb 28, 2024
* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix
udpatil
pushed a commit
that referenced
this pull request
Mar 4, 2024
* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix
udpatil
pushed a commit
that referenced
this pull request
Mar 4, 2024
* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix
udpatil
pushed a commit
that referenced
this pull request
Mar 11, 2024
* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix
udpatil
pushed a commit
that referenced
this pull request
Mar 26, 2024
* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix
udpatil
pushed a commit
that referenced
this pull request
Apr 18, 2024
* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Created ERC20 Template contract to allow native sei tokens to be used as ERC20s
Testing performed to validate your change
foundry unit tests + manual testing.