Skip to content

Create actions-jimo #6719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 1, 2024
Merged

Conversation

imsamdez
Copy link
Contributor

Documentation for the Jimo Browser Destination

Proposed changes

Added an index.md in src/connections/destinations/catalog/actions-jimo/index.md

Merge timing

  • ASAP once approved?

Documentation for the Jimo Browser Destination
@imsamdez imsamdez requested a review from a team as a code owner June 18, 2024 16:25
@imsamdez imsamdez requested review from forstisabella and removed request for a team June 18, 2024 16:25
@forstisabella forstisabella added the new-integration Added a new source or destination label Jun 18, 2024
@forstisabella forstisabella requested a review from tcgilbert June 18, 2024 16:31
imsamdez and others added 4 commits June 18, 2024 18:34
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Oups, sorry about that. Thanks for the changes!

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Thanks.

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
Copy link
Contributor

@tcgilbert tcgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple changes, but lgtm

imsamdez and others added 2 commits June 25, 2024 16:51
Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
Co-authored-by: Thomas Gilbert <64277654+tcgilbert@users.noreply.github.com>
@imsamdez
Copy link
Contributor Author

Committed, thanks for the suggestions!

@tcgilbert
Copy link
Contributor

@imsamdez since you have submitted your documentation. If you have tested the integration, and are certain it behaves as expected, we can make your integration live. Is that the case, or would you like to wait?

@imsamdez
Copy link
Contributor Author

imsamdez commented Jul 1, 2024

@imsamdez since you have submitted your documentation. If you have tested the integration, and are certain it behaves as expected, we can make your integration live. Is that the case, or would you like to wait?

Hey @tcgilbert, you can make it live yes, thanks!

@tcgilbert
Copy link
Contributor

@imsamdez great! this will go live tomorrow afternoon when the docs site rebuilds. I'll send an update to you then

@forstisabella forstisabella merged commit f869334 into segmentio:develop Jul 1, 2024
4 checks passed
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Added a new source or destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants