Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Import Tracking Plan docs [DOC-687] #5678

Merged
merged 9 commits into from
Dec 11, 2023
Merged

Conversation

forstisabella
Copy link
Contributor

@forstisabella forstisabella commented Nov 15, 2023

Proposed changes

Added "Import Tracking Plan" docs

Merge timing

December 11, 2023

Related issues (optional)

#4629

@forstisabella forstisabella marked this pull request as ready for review November 17, 2023 20:32
@forstisabella forstisabella requested review from ranand, a team and pwseg and removed request for a team November 17, 2023 20:32
Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit c56045d
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/656536acada8e300086be34b
😎 Deploy Preview https://deploy-preview-5678--segment-docs.netlify.app/protocols/tracking-plan/create
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

5. Download the Tracking Plan template CSV and fill in the template CSV file with your new Tracking Plan rules, or make changes to your [downloaded Tracking Plan](#download-a-tracking-plan).
6. Once you've filled in the provided template or made changes to your downloaded Tracking Plan, add your CSV file to the file uploader and click **Upload**.

After uploading your CSV file, you are redirected to the Upload & Download History page while the upload is in progress. If the CSV upload fails due to issues with the content of your Tracking Plan, you can download the file `error_report.csv`, which provides you the error in the "Error Details" column of your CSV file. If the upload fails due to issues with the uploaded file itself (a file that is too large, has too many rows, or is not a CSV file, for example), you'll be able to view the error directly in the Reports column.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenxzhang - do we wanna capture common cases in which we generate error_report.csv and cases when we show the error in the upload ui itself?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically there are 3 types of errors: upload ui validation, upload & download history error for the general file itself, and upload & download history error report with specific error details.

  1. upload ui validation (this happens as you upload the file from your local computer)
    Common reasons for error:
  • A filetype other than .csv
  • An empty file
  • A file that is empty besides the header row
  • A CSV file that exceeds 100,000 rows
  • A CSV file that does not have the expected number of columns/headers
  • File name exceeding 80 characters
  1. upload & download history error for the general file itself
  • A CSV file that exceeds 2,000 rules
  • A malformed CSV file (rows have different columns)
  • Internal system errors
  1. upload & download history that generates error_report
  • Invalid label format (should be label:value)
  • Invalid nested property (should be an object or array)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tag!

I'll add a note under the "Upload a Tracking Plan" header with file size/formatting requirements, and make some changes to the troubleshooting section to slim it down.

Copy link
Contributor Author

@forstisabella forstisabella Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay - I removed the "troubleshooting uploads" section and added a sentence after each subsection about the two ways users can see errors on the Upload & Download history page (in commit #c56045d)- is this a step in the right direction? @ranand

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Thanks for incorporating them!

Copy link
Contributor Author

@forstisabella forstisabella Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet! glad to hear it

@forstisabella forstisabella changed the base branch from develop to master December 11, 2023 16:40
@forstisabella forstisabella merged commit e8174ca into master Dec 11, 2023
@forstisabella forstisabella deleted the import-tracking-plans branch December 11, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants