Skip to content

Conversation

catligad
Copy link
Contributor

Background

  • We need to add the logo in the public and in the src files because create-react-app throws an error
Compiled with problems:X

ERROR in ./src/examples/shared/NavBar.tsx 6:0-58

Module not found: Error: You attempted to import ../../../public/segmentlogo.png which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.
You can either move it inside src/, or add a symlink to it from project's node_modules/.

Testing

Testing completed successfully in local via local:
Screen Shot 2022-05-11 at 1 26 11 PM

Deployment Procedure

This page auto deploys

Rollback Procedure

Revert this PR.

@catligad catligad requested a review from a team May 11, 2022 20:28
@catligad catligad changed the title add segment logo to navbar & tab icon add segment logo to navbar & favicon May 11, 2022
@catligad catligad merged commit bd639ea into main May 11, 2022
@catligad catligad deleted the cat-logo branch May 11, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants