Skip to content

Bug/radio indeterminate #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mshwery merged 2 commits into from
Oct 2, 2018
Merged

Bug/radio indeterminate #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
084b117
dont apply indeterminate styles to radios
mshwery Oct 2, 2018
2d44ff4
wip
mshwery Oct 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/radio/stories/index.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,16 @@ storiesOf('radio', module)
document.body.style.margin = '0'
document.body.style.height = '100vh'
})()}
<Heading>Default usage, size 12</Heading>
<Heading>Indeterminate Single Radio (uncommon)</Heading>
<Box aria-label="Radio Group Label 12" role="group">
<Radio name="indeterminate" label="Indeterminate" />
<Radio
checked={false}
name="indeterminate"
label="Indeterminate `checked={false}`"
/>
</Box>
<Heading marginTop={40}>Default usage, size 12</Heading>
<Box aria-label="Radio Group Label 12" role="group">
<Radio checked name="group" label="Radio default" />
<Radio name="group" checked label="Radio checked" />
Expand Down
8 changes: 4 additions & 4 deletions src/themer/src/createCheckboxAppearance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ const disabledState = '&[disabled] + div'
const hoverState = '&:not([disabled]):hover + div'
const focusState = '&:not([disabled]):focus + div'
const activeState = '&:not([disabled]):active + div'
const checkedState = '&:checked + div, &:indeterminate + div'
const checkedState = '&:checked + div, &[type=checkbox]:indeterminate + div'
const checkedHoverState =
'&:not([disabled]):checked:hover + div, &:not([disabled]):indeterminate:hover + div'
'&:not([disabled]):checked:hover + div, &[type=checkbox]:not([disabled]):indeterminate:hover + div'
const checkedActiveState =
'&:not([disabled]):checked:active + div, &:not([disabled]):indeterminate:active + div'
'&:not([disabled]):checked:active + div, &[type=checkbox]:not([disabled]):indeterminate:active + div'
const checkedDisabledState =
'&[disabled]:checked + div, &[disabled]:indeterminate + div'
'&[disabled]:checked + div, &[type=checkbox][disabled]:indeterminate + div'

const hiddenCheckboxStyle = {
border: '0',
Expand Down