Skip to content

[v4] Fix fixed height virtual body #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeroenransijn merged 2 commits into from
Jul 30, 2018
Merged

[v4] Fix fixed height virtual body #270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0696653
fix fixed height virtual body
jeroenransijn Jul 30, 2018
5449ca6
Merge branch 'v4' into fix-advanced-table
jeroenransijn Jul 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/table/src/TableVirtualBody.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ export default class TableVirtualBody extends PureComponent {
} = this.props

// VirtualList needs a fixed height.
const { calculatedHeight } = this.state
const { calculatedHeight, isIntegerHeight } = this.state

return (
<Pane
Expand All @@ -192,7 +192,7 @@ export default class TableVirtualBody extends PureComponent {
{...props}
>
<VirtualList
height={calculatedHeight}
height={isIntegerHeight ? paneHeight : calculatedHeight}
width="100%"
estimatedItemSize={
allowAutoHeight && useAverageAutoHeightEstimation
Expand Down