add focus feedback to segmented controls #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Awesome @bmcmahen! Could you provide a gif or screenshot of the result? |
Contributor
Author
|
here ya go
I think this is the proper behaviour for accessibility. When working through a form using tabs it focuses on the selected radio button initially. Left - right keys shift both focus and radio selection. And the selected state remains when focus shifts to somewhere else on the page. The actual shadow used already existed in your code. |
Contributor
|
I will have to move this in v4 as well! |
Contributor
|
|
prateekgoel
pushed a commit
to prateekgoel/evergreen
that referenced
this pull request
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed focus feedback in segmented controls for accessibility purposes... so here's my quick solution. Just noticed that this should address #229.