Skip to content

allow passthrough props on menu item, and always bubble highjacked ev… #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeroenransijn merged 1 commit into from
Jul 18, 2018
Merged

allow passthrough props on menu item, and always bubble highjacked ev… #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions src/menu/src/MenuItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,20 +54,30 @@ class MenuItem extends React.PureComponent {
is: 'div',
intent: 'none',
appearance: 'default',
onClick: () => {},
onSelect: () => {},
onKeyPress: () => {}
onSelect: () => {}
}

handleClick = () => {
this.props.onSelect()
handleClick = event => {
this.props.onSelect(event)

/* eslint-disable react/prop-types */
if (typeof this.props.onClick === 'function') {
this.props.onClick(event)
}
/* eslint-enable react/prop-types */
}

handleKeyPress = e => {
if (e.key === 'Enter' || e.key === ' ') {
this.props.onSelect()
e.preventDefault()
handleKeyPress = event => {
if (event.key === 'Enter' || event.key === ' ') {
this.props.onSelect(event)
event.preventDefault()
}

/* eslint-disable react/prop-types */
if (typeof this.props.onKeyPress === 'function') {
this.props.onKeyPress(event)
}
/* eslint-enable react/prop-types */
}

render() {
Expand All @@ -78,7 +88,8 @@ class MenuItem extends React.PureComponent {
appearance,
secondaryText,
intent,
icon
icon,
...passthroughProps
} = this.props

const themedClassName = theme.getMenuItemClassName(appearance, 'none')
Expand All @@ -95,6 +106,7 @@ class MenuItem extends React.PureComponent {
data-isselecteable="true"
display="flex"
alignItems="center"
{...passthroughProps}
>
{icon && (
<Icon
Expand Down