fix windows build #1674
Open
fix windows build #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for evergreen-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
maxrchung
commented
Feb 13, 2024
There was a problem hiding this comment.
Note: I didn't update all of the scripts. I left update-docs as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I would like to run this project on Windows but encountered some issues trying to run some of the scripts. In this PR, I adjusted a few things to make
yarn buildandyarn devwork:cross-envto set environment variables in script.rimrafto remove files.I verified on my Windows and Mac machines that
yarn buildandyarn devwere successful after the changes. One thing separately I also noticed was that Node 18 did not seem to be supported, and I had to downgrade to Node 16 in order to run the project.Screenshots (if applicable)
N/A
Documentation