fix deselect/select on multiple select menus, optimize perf, remove broken context #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for evergreen-storybook ready! 🔨 Explore the source changes: 4002569 🔍 Inspect the deploy log: https://app.netlify.com/sites/evergreen-storybook/deploys/60ef4a49d091d90007673805 😎 Browse the preview: https://deploy-preview-1256--evergreen-storybook.netlify.app |
|
✔️ Deploy Preview for evergreen-storybook ready! 🔨 Explore the source changes: 9d65d7f 🔍 Inspect the deploy log: https://app.netlify.com/sites/evergreen-storybook/deploys/60ef5f9b7c15ef0008fda820 😎 Browse the preview: https://deploy-preview-1256--evergreen-storybook.netlify.app |
dlasky
approved these changes
Jul 14, 2021
akleiner2
approved these changes
Jul 14, 2021
This was referenced Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the performance of tables, and the SelectMenu while fixing a buggy behavior when deselecting/reselecting the same item with
multiple={true}Supersedes #1247 and #1142
Screenshots (if applicable)
NA
Documentation