all: replace segmentio/go-sqlite3 fork with upstream #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our fork does not build on latest version of Alpine, due to a change in the API that has been fixed upstream but not backported. The fork only supported two commits. Both commits have been merged upstream, but one - mattn/go-sqlite3#736 - is behind a build tag, which is why we need to add a build tag here.
kevinburkesegment
requested review from
erikdw and
kalamay
and removed request for
a team
|
I'm definitely in favor of relying on the upstream version rather than our own if we can make sure that other downstream dependencies will build with this tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our fork does not build on latest version of Alpine, due to a change in the API that has been fixed upstream but not backported.
The fork only supported two commits. Both commits have been merged upstream, but one - mattn/go-sqlite3#736 - is behind a build tag, which is why we need to add a build tag here.