Skip to content

Update Kissmetric domain and bump kissmetric integrations version #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion integrations/kissmetrics/HISTORY.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
2.2.0 / 2020-06-17
==================

* Update domain

2.1.1 / 2016-09-06
==================
Expand Down Expand Up @@ -73,4 +77,4 @@
1.0.0 / 2015-06-09
==================

* Initial commit :sparkles:
* Initial commit :sparkles:
8 changes: 3 additions & 5 deletions integrations/kissmetrics/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,11 @@ var KISSmetrics = (module.exports = integration('KISSmetrics')
.option('trackNamedPages', true)
.tag(
'library',
'<script src="//scripts.kissmetrics.com/{{ apiKey }}.2.js">'
'<script src="//scripts.kissmetrics.io/{{ apiKey }}.2.js">'
));

/**
* Check if browser is mobile, for kissmetrics.
*
* http://support.kissmetrics.com/how-tos/browser-detection.html#mobile-vs-non-mobile
*/

exports.isMobile =
Expand All @@ -45,7 +43,7 @@ exports.isMobile =
/**
* Initialize.
*
* http://support.kissmetrics.com/apis/javascript
* https://support.kissmetrics.io/docs/javascript-library
*/

KISSmetrics.prototype.initialize = function() {
Expand Down Expand Up @@ -136,7 +134,7 @@ KISSmetrics.prototype.track = function(track) {
if (revenue) {
// legacy: client side integration used to only send 'Billing Amount', but
// our server side sent both 'revenue' and 'Billing Amount'. From the docs,
// http://support.kissmetrics.com/tools/revenue-report.html, ther is no
// https://support.kissmetrics.io/docs/revenue-report-1, there is no
// reason to send it as 'Billing Amount', but we don't want to break reports
// so we send it as 'revenue' and 'Billing Amount' for consistency across
// platforms.
Expand Down
2 changes: 1 addition & 1 deletion integrations/kissmetrics/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@segment/analytics.js-integration-kissmetrics",
"description": "The Kissmetrics analytics.js integration.",
"version": "2.1.2",
"version": "2.2.0",
"keywords": [
"analytics.js",
"analytics.js-integration",
Expand Down