Skip to content

[HGI 404] update pinned version of sentry to 7.45.0 #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AnkitUnthinkable
Copy link
Contributor

@AnkitUnthinkable AnkitUnthinkable commented Mar 27, 2023

What does this PR do?

In this PR includes

  1. sentry update from version 5.12.1 to 7.45.0 (latest).
  2. We are using pluggable integrations RewriteFrame which is also getting updated from 5.12.1 to 7.45.0 (latest).
  3. Sentry options whitelistURLs and blacklistURLs are changed to allowURLs and denyURLs.
  4. Sentry options serverName and maxMessageLength is no longer available.

Testing Docs: https://paper.dropbox.com/doc/Sentry-version-upgrade-v5.12.1-to-v7.45.0-Testing-Docs.--B2Jx3D2y_~_YtsXrYJ1W1sssAQ-hdyjHRh7cPrSg7AoMg66Y

Testing

Testing completed successfully in localhost

Jira tickets:
https://segment.atlassian.net/browse/HGI-404?atlOrigin=eyJpIjoiMGVmZDgwYWExMWI2NGNjNThmZjhmZTc3ZWYwM2FjNzMiLCJwIjoiaiJ9

PREVIOUS VERSION

Screenshot 2023-03-28 at 5 22 16 AM

Current Version

Screenshot 2023-03-28 at 5 21 50 AM

Copy link
Contributor

@varadarajan-tw varadarajan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we ensure test cases are updated? Also, since this is a major version upgrade, can we confirm all fields and settings are working as expected?.

@varadarajan-tw varadarajan-tw requested a review from brennan March 28, 2023 06:21
@varadarajan-tw
Copy link
Contributor

Copy link
Contributor

@varadarajan-tw varadarajan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few more questions and comments

@varadarajan-tw varadarajan-tw self-requested a review April 13, 2023 13:28
@varadarajan-tw
Copy link
Contributor

The changes look good!
We are deprecating two settings

  1. ServerName - It was never supported for browser SDK by Sentry
  2. MaxMessageLength - It was already unsupported in the previous version this destination was on.

@brennan - Any thoughts on whether to delete such deprecated settings from partner portal or just add deprecation warning and leave it as such?
Note: There is no cloud mode destination for Sentry.

@varadarajan-tw varadarajan-tw changed the title Hgi 404 update our pinned version of sentry to v 7 27 2 [HGI 404] update our pinned version of sentry to 7.45.0 Apr 13, 2023
@varadarajan-tw varadarajan-tw changed the title [HGI 404] update our pinned version of sentry to 7.45.0 [HGI 404] update pinned version of sentry to 7.45.0 Apr 13, 2023
@brennan
Copy link
Contributor

brennan commented Apr 13, 2023

Hey @varadarajan-tw - I'm a fan of deprecating settings- as long as we test first in stage b/c we don't have a specific process for deprecating or removing settings other than simply deleting from partner portal. Simply deleting them from partner portal should be ok, so long as we're not doing any operations on the setting in integrations-consumer or the monoservice, e.g. ServerName.length or something.

tl;dr - it's ok to leave them, but if there is time, it may be a good opportunity to document a process for removing deprecated settings. If so, then we should document and remove these.

@AnkitUnthinkable AnkitUnthinkable merged commit b1e9a7a into master Apr 17, 2023
@AnkitUnthinkable AnkitUnthinkable deleted the HGI-404-update-our-pinned-version-of-sentry-to-v-7-27-2 branch April 17, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants