-
Notifications
You must be signed in to change notification settings - Fork 144
[HGI 404] update pinned version of sentry to 7.45.0 #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HGI 404] update pinned version of sentry to 7.45.0 #741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we ensure test cases are updated? Also, since this is a major version upgrade, can we confirm all fields and settings are working as expected?.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few more questions and comments
The changes look good!
@brennan - Any thoughts on whether to delete such deprecated settings from partner portal or just add deprecation warning and leave it as such? |
Hey @varadarajan-tw - I'm a fan of deprecating settings- as long as we test first in stage b/c we don't have a specific process for deprecating or removing settings other than simply deleting from partner portal. Simply deleting them from partner portal should be ok, so long as we're not doing any operations on the setting in tl;dr - it's ok to leave them, but if there is time, it may be a good opportunity to document a process for removing deprecated settings. If so, then we should document and remove these. |
What does this PR do?
In this PR includes
Testing Docs: https://paper.dropbox.com/doc/Sentry-version-upgrade-v5.12.1-to-v7.45.0-Testing-Docs.--B2Jx3D2y_~_YtsXrYJ1W1sssAQ-hdyjHRh7cPrSg7AoMg66Y
Testing
Testing completed successfully in localhost
Jira tickets:
https://segment.atlassian.net/browse/HGI-404?atlOrigin=eyJpIjoiMGVmZDgwYWExMWI2NGNjNThmZjhmZTc3ZWYwM2FjNzMiLCJwIjoiaiJ9
PREVIOUS VERSION
Current Version