[Compiler Tool] Improve error handling when we can't fetch settings. #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omegabytes
reviewed
Dec 4, 2019
compiler/scripts/settings.js
Outdated
| @@ -19,12 +19,11 @@ async function getSourceSettings(writeKey) { | |||
| request.get({ url: url, gzip: true }, (err, _, body) => { | |||
| if (err) { | |||
| reject(err); | |||
| } else if (body && body.includes('Invalid path or write key provided.')) { | |||
| console.error('Please make sure your Segment writeKey was entered correctly.') | |||
There was a problem hiding this comment.
"More info: https://segment.com/docs/connections/find-writekey"
omegabytes
approved these changes
Dec 4, 2019
brennan
changed the title
patrickotoole
pushed a commit
to rockerbox/analytics.js-integrations
that referenced
this pull request
Feb 27, 2020
…egmentio#298) * [Compiler Tool] Improve error handling when we can't fetch settings.
marinhero
pushed a commit
to Wootric/analytics.js-integrations-1
that referenced
this pull request
Apr 24, 2020
…egmentio#298) * [Compiler Tool] Improve error handling when we can't fetch settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
yarn install --no-lockfileif the output ofgit diff --name-onlyis truthy.