Don't swallow integration errors #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2prateek
requested review from
tysonmote,
dominicbarnes,
danielstjules,
tamarrow-zz,
CarlosMecha,
tsholmes,
Peripheral1994,
ccnixon and
jlee9595
As part of adding client side metrics, we want to propagate errors to analytics.js-core so that it can capture them. https://paper.dropbox.com/doc/Analytics.js-Metrics-SDD-1hAD90lqGS4aZxHAHYPu7#:h2=analytics.js-integration analytics.js-core has already been updated to capture errors when invoking integrations (segmentio/analytics.js-core#66).
|
I should clarify that a.js-core hasn't been updated yet - the PR is in review, and I'll be merging this only after the a.js-core changes in segmentio/analytics.js-core#66 are merged. |
|
Hey @f2prateek - we have this in place to ensure that if a single integration has a bug and errors, it won't cause the all other integrations to also crash. I think we definitely want to maintain this behavior. |
|
Sorry disregard! I mixed up your commits. |
f2prateek
added a commit
that referenced
this pull request
May 17, 2018
Same as #60 but for 2.x. As part of adding client side metrics, we want to propagate errors to analytics.js-core so that it can capture them. https://paper.dropbox.com/doc/Analytics.js-Metrics-SDD-1hAD90lqGS4aZxHAHYPu7#:h2=analytics.js-integration analytics.js-core has already been updated to capture errors when invoking integrations (segmentio/analytics.js-core#66).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of adding client side metrics, we want to propagate errors to analytics.js-core so that it can capture them.
https://paper.dropbox.com/doc/Analytics.js-Metrics-SDD-1hAD90lqGS4aZxHAHYPu7#:h2=analytics.js-integration
analytics.js-core has already been updated to capture errors when invoking integrations (segmentio/analytics.js-core#66).