Added Logger and SegmentLogger plugin. #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsneed
approved these changes
Sep 17, 2021
| @@ -122,7 +122,7 @@ extension UIViewController { | |||
| guard let top = Self.seg__visibleViewController(activeController()) else { return } | |||
|
|
|||
| var name = String(describing: top.self.classForCoder).replacingOccurrences(of: "ViewController", with: "") | |||
| print(name) | |||
| analytics?.log(message: name) | |||
There was a problem hiding this comment.
this should probably be more descriptive than just the name of the view. ie: "Auto-tracking Screen: (name)"
| } | ||
| return event | ||
| } | ||
|
|
||
| // we also want to know when settings are retrieved or changed. | ||
| func update(settings: Settings) { | ||
| let json = settings.prettyPrint() | ||
| print("settings updated on instance: \(name)") | ||
| print("\(json)\n") | ||
| analytics?.log(message: "settings updated on instance: \(name)") |
There was a problem hiding this comment.
these can probably be combined into a single call.
| @@ -250,7 +250,7 @@ extension AppsFlyerDestination: AppsFlyerLibDelegate { | |||
| extension AppsFlyerDestination: DeepLinkDelegate, UIApplicationDelegate { | |||
|
|
|||
| func didResolveDeepLink(_ result: DeepLinkResult) { | |||
| print(result) | |||
| analytics?.log(message: result) | |||
There was a problem hiding this comment.
this should be more descriptive rather than just the deep link result.
bsneed
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Logger and SegmentLogger plugin. Added print target and system target (osLog). Contains flag for sending based on if settings is updated to stop logging.