Skip to content

Add objective-c compatibility / example #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 18, 2021
Merged

Add objective-c compatibility / example #39

merged 10 commits into from
Aug 18, 2021

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Aug 13, 2021 •
edited
Loading

  • Added wrappers to support ObjC basics, such as track/identify/flush/etc.
  • Added objc example app.
  • Added objc example app to CI build process.
  • Added tests to verify non-trivial pass-through methods.

migs647
migs647 reviewed Aug 16, 2021
View reviewed changes
Examples/apps/ObjCExample/ObjCExample/AppDelegate.m
- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
// Override point for customization after application launch.
SEGConfiguration *config = [[SEGConfiguration alloc] initWithWriteKey:@"WRITE_KEY"];
config.trackApplicationLifecycleEvents = TRUE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TRUE == YES

migs647
migs647 reviewed Aug 16, 2021
View reviewed changes
Sources/Segment/ObjC/ObjCAnalytics.swift
@@ -0,0 +1,161 @@
//
// File.swift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File.swift

migs647
migs647 reviewed Aug 16, 2021
View reviewed changes
Sources/Segment/ObjC/ObjCConfiguration.swift
@@ -0,0 +1,132 @@
//
// File.swift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File.swift

migs647
migs647 approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@migs647 migs647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with bool fix

alanjcharles
alanjcharles approved these changes Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@alanjcharles alanjcharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for walking me through! Looks good

@bsneed bsneed merged commit e35f7f1 into main Aug 18, 2021
@bsneed bsneed deleted the bsneed/objc branch August 18, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migs647 migs647 migs647 approved these changes

@alanjcharles alanjcharles alanjcharles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsneed @migs647 @alanjcharles