Skip to content

Plugin Interface refactor #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2021
Merged

Plugin Interface refactor #35

merged 4 commits into from
Aug 5, 2021

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Aug 4, 2021 •
edited
Loading

  • Removes the name property entirely.
  • Removes need for plugin.init(name: )
  • Changes analytics.find(pluginName: ) to be analytics.find(pluginType: )
  • Adds key property on DestinationPlugin to be used for settings lookup and integration name.
  • Makes all necessary example app/plugin changes.

prayansh
prayansh reviewed Aug 4, 2021
View reviewed changes
prayansh
prayansh approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@prayansh prayansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but i aint a swift expert

@bsneed bsneed merged commit f1138bf into main Aug 5, 2021
@bsneed bsneed deleted the bsneed/plugin_refactor branch August 5, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prayansh prayansh prayansh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsneed @prayansh