Add release automation script. #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bsneed
commented
Aug 3, 2021
bsneed
commented
- Added release.sh
- Updated releasing.md
- Added safety text in Version.swift to deter by-hand modification.
prayansh
reviewed
Aug 3, 2021
| // DO NOT MODIFY THIS FILE BY HAND!! | ||
| // DO NOT MODIFY THIS FILE BY HAND!! | ||
| // DO NOT MODIFY THIS FILE BY HAND!! | ||
| // DO NOT MODIFY THIS FILE BY HAND!! |
prayansh
reviewed
Aug 3, 2021
release.sh
Outdated
| exit 1 | ||
| fi | ||
|
|
||
| versionFile="./sources/Segment/version.swift" |
There was a problem hiding this comment.
not sure if V needs to be uppercase
There was a problem hiding this comment.
case insensitive file system; but yeah it should be.
prayansh
reviewed
Aug 3, 2021
| vercomp () { | ||
| if [[ $1 == $2 ]] | ||
| then | ||
| return 0 |
There was a problem hiding this comment.
if the new version is the same as old version, we should error out, right?
prayansh
reviewed
Aug 3, 2021
| changelog=git log --pretty=format:"- (%an) %s" $(git describe --tags --abbrev=0 @^)..@ | ||
| tempFile=$(mktemp) | ||
| #write changelog to temp file. | ||
| echo $changelog >> $tempFile |
There was a problem hiding this comment.
whats the reason for a temp file?
There was a problem hiding this comment.
I write the changelog out there, and then gh release will read it in from there.
prayansh
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.