Skip to content

Bsneed/queueing #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 7, 2021
Merged

Bsneed/queueing #24

merged 7 commits into from
Jun 7, 2021

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Jun 4, 2021 •
edited
Loading

  • Added started property to System state.
  • Added StartupQueue plugin that will effectively pause event processing until plugins have started.
  • Accounts for plugins added much later and resumes queueing until started.

migs647
migs647 approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@migs647 migs647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGrrrrreatTM 🐯

@prayansh prayansh self-requested a review June 7, 2021 17:49
prayansh
prayansh approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@prayansh prayansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

migs647
migs647 approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@migs647 migs647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with limits

@bsneed bsneed merged commit 3e2b35b into main Jun 7, 2021
@bsneed bsneed deleted the bsneed/queueing branch June 7, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migs647 migs647 migs647 approved these changes

@prayansh prayansh prayansh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsneed @migs647 @prayansh