Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 34 additions & 7 deletions lib/segment/analytics/logging.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,43 @@

module Segment
class Analytics
# Wraps an existing logger and adds a prefix to all messages
class PrefixedLogger
def initialize(logger, prefix)
@logger = logger
@prefix = prefix
end

def debug(msg)
@logger.debug("#{@prefix} #{msg}")
end

def info(msg)
@logger.info("#{@prefix} #{msg}")
end

def warn(msg)
@logger.warn("#{@prefix} #{msg}")
end

def error(msg)
@logger.error("#{@prefix} #{msg}")
end
end

module Logging
class << self
def logger
@logger ||= if defined?(Rails)
Rails.logger
else
logger = Logger.new STDOUT
logger.progname = 'Segment::Analytics'
logger
end
return @logger if @logger

base_logger = if defined?(Rails)
Rails.logger
else
logger = Logger.new STDOUT
logger.progname = 'Segment::Analytics'
logger
end
@logger = PrefixedLogger.new(base_logger, '[analytics-ruby]')
end

attr_writer :logger
Expand Down
1 change: 1 addition & 0 deletions lib/segment/analytics/request.rb
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ def retry_with_backoff(retries_remaining, &block)
end

if should_retry && (retries_remaining > 1)
logger.debug("Retrying request, #{retries_remaining} retries left")
sleep(@backoff_policy.next_interval.to_f / 1000)
retry_with_backoff(retries_remaining - 1, &block)
else
Expand Down
2 changes: 2 additions & 0 deletions lib/segment/analytics/worker.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ class Analytics
class Worker
include Segment::Analytics::Utils
include Segment::Analytics::Defaults
include Segment::Analytics::Logging

# public: Creates a new worker
#
Expand Down Expand Up @@ -44,6 +45,7 @@ def run
end
end

logger.debug("Sending request for #{@batch.length} items")
res = @request.post(@write_key, @batch)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @rohitpaulk, as a follow up; let's log the result of the HTTP response. I think the status code might be helpful to have here.

@on_error.call(res.status, res.error) unless res.status == 200

Expand Down