Add exponential backoff #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 98.85% 98.74% -0.11%
==========================================
Files 12 14 +2
Lines 612 799 +187
==========================================
+ Hits 605 789 +184
- Misses 7 10 +3
Continue to review full report at Codecov.
|
f2prateek
reviewed
Dec 5, 2017
| @@ -6,15 +6,22 @@ module Request | |||
| PORT = 443 | |||
| PATH = '/v1/import' | |||
| SSL = true | |||
| HEADERS = { :accept => 'application/json' } | |||
There was a problem hiding this comment.
was this previously unused?
There was a problem hiding this comment.
Yes. It was being assigned to a variable, but the actual headers used were hardcoded.
(The diff for this individual commit includes all the relevant files).
f2prateek
approved these changes
Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds exponential backoff when requests are retried.
I picked the default backoff parameter values from https://github.com/segmentio/analytics-go and https://github.com/segmentio/backo-go.