Skip to content

Continuation - Since our CMS Drupal does occasionally assign the value zero to userID #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
btruong wants to merge 3 commits into from
Closed

Continuation - Since our CMS Drupal does occasionally assign the value zero to userID #82

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2de0e35
Since our CMS Drupal does occsioanlly assign the value zero to userID…
btruong Sep 22, 2016
6d53145
Merge branch 'master' into master
nd4p90x Feb 2, 2021
7739d5a
Merge branch 'master' into master
nd4p90x Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/Segment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ public static function identify(array $message) {
public static function group(array $message) {
self::checkClient();
$groupId = !empty($message["groupId"]);
self::assert($groupId, "Segment::group() expects groupId");
$userId = !(array_key_exists('userID', $message) && strlen((string) $message['userID']) > 0);

self::assert($groupId && $userId, "Segment::group() expects userId and groupId");
self::validate($message, "group");

return self::$client->group($message);
Expand Down Expand Up @@ -93,8 +95,8 @@ public static function screen(array $message) {
*/
public static function alias(array $message) {
self::checkClient();
$userId = !empty($message["userId"]);
$previousId = !empty($message["previousId"]);
$userId = !(array_key_exists('userID', $message) && strlen((string) $message['userID']) > 0);
$previousId = !(array_key_exists('previousId', $message) && strlen((string) $message['previousId']) > 0);
self::assert($userId && $previousId, "Segment::alias() requires both userId and previousId");

return self::$client->alias($message);
Expand All @@ -107,7 +109,7 @@ public static function alias(array $message) {
* @param string $type
*/
public static function validate($msg, $type){
$userId = !empty($msg["userId"]);
$userId = !(array_key_exists('userID', $msg) && strlen((string) $msg['userID']) > 0);
$anonId = !empty($msg["anonymousId"]);
self::assert($userId || $anonId, "Segment::${type}() requires userId or anonymousId");
}
Expand Down