Skip to content

File permission option for file consumer#122

Merged
nd4p90x merged 5 commits intosegmentio:masterfrom
remyfrd:master
Jan 13, 2021
Merged

File permission option for file consumer#122
nd4p90x merged 5 commits intosegmentio:masterfrom
remyfrd:master

Conversation

@remyfrd
Copy link
Contributor

@remyfrd remyfrd commented Nov 20, 2018

I just taken an old PR: #26

I really need this.
We have many error with this chmod(..., 0777) like this in prod: chmod(): Operation not permitted

@codecov-io
Copy link

codecov-io commented Nov 20, 2018

Codecov Report

Merging #122 into master will increase coverage by 0.33%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #122      +/-   ##
============================================
+ Coverage     89.84%   90.18%   +0.33%     
- Complexity      124      125       +1     
============================================
  Files             8        8              
  Lines           384      387       +3     
============================================
+ Hits            345      349       +4     
+ Misses           39       38       -1
Impacted Files Coverage Δ Complexity Δ
lib/Segment/Consumer/File.php 97.14% <100%> (+3.39%) 16 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db4809a...98380a9. Read the comment docs.

@thibaudcharrier
Copy link

Same error for a Laravel app, the chmod raise an error, but segment reporting is working fine.
This chmod seems to be useless.

@f2prateek f2prateek removed their request for review July 2, 2019 21:12
Copy link
Collaborator

@nd4p90x nd4p90x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you

@nd4p90x nd4p90x merged commit e0872bd into segmentio:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants