fix: bump is-email resolution to 1.x, 0.1.1 is also curation-blocked - #1388
Merged
Conversation
Same pattern as #1386's axios fix: `is-email@0.1.1` (the version #1385 picked as "newest within the same major") is also curation-blocked - every 0.x release is. Unlike axios and the other 40 packages in that PR, this one is a real behavior change: is-email is bundled into the shipped @segment/analytics-next bundle via @segment/facade (a real runtime dependency, not dev tooling), used for email-trait detection in identify/track/page/group processing. 0.1.1's matcher (/.+@.+\..+/) is very loose - matches almost anything shaped like x@y.z. 1.0.2 (the only available non-blocked version) uses a proper RFC-5321-style pattern plus a 320-character cap, so this makes that internal detection meaningfully stricter. Documented as its own changeset rather than folding it into the mechanical bump commits, since it's the one exception among all the curation-driven bumps that touches real shipped behavior. Verified locally: full browser test suite (70/70 suites, 841/845 tests) still passes.
✅ TVS Validation PassedShow detailsAll validation checks have successfully completed. |
🦋 Changeset detectedLatest commit: 5af61b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CI caught a real break from the axios bump (#1386): wait-on@6.0.1 (used by jest-dev-server, dev-only) does a hardcoded `require('axios/lib/adapters/http')` - an internal axios 0.x file path that doesn't exist in the 1.x rewrite. Forcing axios to 1.x for the curation-blocked resolutions broke wait-on unconditionally, regardless of which axios version it resolved to, since no curation-approved axios version has that internal path anymore. Bumps wait-on itself to 9.0.10 (its public API - waitOn(opts, callback) - hasn't changed) rather than trying to keep it on an old, curation-blocked axios. Dev-only, no published-package impact. Verified locally: e2e-tests/performance passes again (2/2), and full `make ci` for browser is green end to end.
abueide
enabled auto-merge (squash)
July 17, 2026 20:36
didiergarcia
approved these changes
Jul 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit 5af61b5 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## master #1388 +/- ##
==========================================
+ Coverage 89.74% 91.59% +1.85%
==========================================
Files 46 127 +81
Lines 1375 4142 +2767
Branches 322 1033 +711
==========================================
+ Hits 1234 3794 +2560
- Misses 141 348 +207
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same pattern as #1386's axios fix:
is-email@0.1.1(the version #1385 picked as "newest within the same major") is also curation-blocked - every 0.x release is.Unlike axios, this one is a real (narrow) behavior change
is-emailis bundled into the shipped@segment/analytics-nextbundle via@segment/facade(a real runtime dependency, not dev tooling), used for email-trait detection inidentify/track/page/groupprocessing.is-email@0.1.1's matcher:/.+@.+\..+/- very loose, matches almost anything shaped likex@y.zis-email@1.0.2(the only available non-blocked version): a proper RFC-5321-style pattern, plus a 320-character capSo this makes that internal detection meaningfully stricter. Added as its own changeset (
.changeset/bump-is-email-curation.md) documenting the behavior change, rather than folding it into the mechanical bump commits like the other 40 packages.A second real break found via CI: wait-on incompatible with axios 1.x
wait-on@6.0.1(used byjest-dev-server, dev-only) does a hardcodedrequire('axios/lib/adapters/http')- an internal axios 0.x file path that doesn't exist in the 1.x rewrite (#1386). No curation-approved axios version has that path anymore, so this broke unconditionally once axios was forced to 1.x. Bumpedwait-onitself to 9.0.10 - its public API (waitOn(opts, callback)) is unchanged, and it's dev-only (no published-package impact).Verified locally
e2e-tests/performance(the suite that caught the wait-on/axios break): 2/2make cifor browser green end to endis-emailfix against real curated Artifactory via a manualrelease.ymltrigger on this branch: thetestjob (Node 20) installs cleanlyTest plan
publishjob's install (Node 24) also resolves cleanly once merged - a scratch-branch dispatch can't reach that job (theproductionenvironment correctly rejects non-masterdeployments), so this can only be confirmed after merge