fix api host being overwritten by default value #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wenxi-zeng
commented
Mar 24, 2022
wenxi-zeng
commented
- fix api host being overwritten by default value
- now the apiHost value honors in the following order: remote apiHost > local modified apiHost > default apiHost
prayansh
reviewed
Mar 24, 2022
| @@ -95,8 +95,8 @@ class SegmentDestination : DestinationPlugin(), VersionedPlugin { | |||
| override fun update(settings: Settings, type: Plugin.UpdateType) { | |||
| super.update(settings, type) | |||
| if (settings.hasIntegrationSettings(this)) { | |||
| settings.destinationSettings<SegmentSettings>(key)?.let { | |||
| pipeline.apiHost = it.apiHost | |||
| settings.destinationSettings<SegmentSettings>(key)?.apiHost?.let { | |||
There was a problem hiding this comment.
OMG thats so subtle of a difference 😓 . Lets add a comment here indicating that we only want to populate the apiHost value if it exists
prayansh
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.