Skip to content

Wenxi/suspendable analytics #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Oct 13, 2021
Merged

Wenxi/suspendable analytics #50

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
af8ab3e
init changes to make sdk suspendable
wenxi-zeng Sep 30, 2021
b7b0a7c
get ride of singleton dispatchers
wenxi-zeng Sep 30, 2021
a4f8a95
fix configuration issue
wenxi-zeng Sep 30, 2021
b4fccba
fix unit test errors
wenxi-zeng Sep 30, 2021
92da21a
fix android errors
wenxi-zeng Sep 30, 2021
05b4fb0
fix android unit tests errors
wenxi-zeng Sep 30, 2021
eba63a1
fix destination unit tests errors
wenxi-zeng Sep 30, 2021
318dafe
remove weak reference from SegmentDestination.kt
wenxi-zeng Oct 7, 2021
0816c14
update settings to use withContext
wenxi-zeng Oct 7, 2021
0161bb4
refactor dispatcher to be injectable
wenxi-zeng Oct 11, 2021
1f0329b
fix core unit tests
wenxi-zeng Oct 11, 2021
f4d15c4
fix android unit tests
wenxi-zeng Oct 11, 2021
dbbac1b
fix destination unit tests
wenxi-zeng Oct 11, 2021
978f999
separate base data for accuracy
wenxi-zeng Oct 11, 2021
f2da078
fix unit test
wenxi-zeng Oct 11, 2021
fcf1095
add blocking api warning
wenxi-zeng Oct 11, 2021
90e00cf
fix JavaAnalytics.kt
wenxi-zeng Oct 11, 2021
0943cf3
refactor annotation class to a separate file
wenxi-zeng Oct 12, 2021
aec1f5e
update sovran version
wenxi-zeng Oct 13, 2021
523510d
add comments to constructors
wenxi-zeng Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix destination unit tests errors
  • Loading branch information
@wenxi-zeng
wenxi-zeng committed Sep 30, 2021
commit eba63a19ae4c4a8b1bb3f5ec430d5325627198fc
3 changes: 2 additions & 1 deletion ...tions/src/test/java/com/segment/analytics/destinations/plugins/IntercomDestinationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import io.mockk.*
import io.mockk.impl.annotations.MockK
import kotlinx.coroutines.CoroutineDispatcher
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.runBlocking
import kotlinx.coroutines.test.TestCoroutineDispatcher
import kotlinx.coroutines.test.TestCoroutineScope
import kotlinx.serialization.json.JsonObject
Expand Down Expand Up @@ -97,7 +98,7 @@ internal class IntercomDestinationTest {
}

@Test
fun `intercom client not re-initialized when settings is fresh`() {
fun `intercom client not re-initialized when settings is fresh`() = runBlocking {
analytics.add(intercomDestination)
analytics.checkSettings()
verify (exactly = 1) {
Expand Down