-
Notifications
You must be signed in to change notification settings - Fork 32
support enable/disable analytics #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wenxi-zeng
commented
Jun 2, 2023
- support enable/disable analytics
- fix log leaks
- fix non-hierarchical deeplink crash
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
============================================
+ Coverage 79.28% 84.56% +5.27%
+ Complexity 474 466 -8
============================================
Files 74 66 -8
Lines 5968 5196 -772
Branches 721 656 -65
============================================
- Hits 4732 4394 -338
+ Misses 667 247 -420
+ Partials 569 555 -14
☔ View full report in Codecov by Sentry. |
for (parameter in uri.queryParameterNames) { | ||
val value = uri.getQueryParameter(parameter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use "it" instead of "uri" to keep consistent?
if (writeChannel.isClosedForSend || writeChannel.isClosedForReceive) { | ||
writeChannel = Channel(UNLIMITED) | ||
uploadChannel = Channel(UNLIMITED) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use a new channel is possible we leave messages that are stuck in the pipe and loose them when we create a new pipe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah. that's possible. but we're using channel.cancel
in stop
, buffered events are going to be cleared anyway
the only workaround is not to close/cancel channel at all, but that increases the complexity, since we would have to distinguish pause vs stop. if stop, we would want to close anything ongoing completely, for example on application shutdown.