LIBMOBILE-1277- fix androidx lifecycle causes analytics init in background crash #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix androidx lifecycle causes analytics init in background crash
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
=============================================
+ Coverage 45.57% 79.26% +33.69%
- Complexity 14 474 +460
=============================================
Files 8 74 +66
Lines 858 5965 +5107
Branches 85 719 +634
=============================================
+ Hits 391 4728 +4337
- Misses 437 670 +233
- Partials 30 567 +537 ☔ View full report in Codecov by Sentry. |
wenxi-zeng
requested changes
Apr 28, 2023
| run(Runnable { lifecycle.removeObserver(this) }) | ||
| } | ||
| } | ||
| private fun run(runnable: Runnable) { |
There was a problem hiding this comment.
you don't have to use runnable in kotlin, try high order function and lambda
| if (Looper.myLooper() == Looper.getMainLooper()) { | ||
| runnable.run() | ||
| } else { | ||
| HANDLER.post(runnable) |
There was a problem hiding this comment.
in kotlin, the correct way to post to main thread is
scope.launch(Dispatchers.Main) {
// do something on main thread
}
wenxi-zeng
requested review from
didiergarcia and
wenxi-zeng
and removed request for
wenxi-zeng
didiergarcia
approved these changes
May 9, 2023
wenxi-zeng
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LIBMOBILE-1277