Skip to content

retrieve the legacy build number as an integer instead of a string. #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

didiergarcia
Copy link
Contributor

Found an error when I tested this tomorrow while working on something else.

I was reading the legacy build as a String, but it was stored as an Integer, but while you might expect this to work, it actually throws a runtime exception and crashes the app.

So now instead we'll have to retrieve the legacy build number as an Integer.

@didiergarcia didiergarcia requested a review from wenxi-zeng April 21, 2023 04:12
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (d7e6d4b) 79.29% compared to head (666f36d) 79.26%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #156      +/-   ##
============================================
- Coverage     79.29%   79.26%   -0.04%     
+ Complexity      475      474       -1     
============================================
  Files            74       74              
  Lines          5965     5965              
  Branches        719      719              
============================================
- Hits           4730     4728       -2     
- Misses          669      670       +1     
- Partials        566      567       +1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@didiergarcia didiergarcia merged commit 35170e0 into main Apr 21, 2023
@didiergarcia didiergarcia deleted the fix-exception-getting-legacy-build branch April 21, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants