Skip to content

add api for identify using only traits #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Conversation

prayansh
Copy link
Contributor

Adds new api fun Analytics.identify(traits) that allows users to update traits without needing userId

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Merging #107 (21ac665) into main (6584e34) will increase coverage by 0.01%.
The diff coverage is 80.85%.

@@             Coverage Diff              @@
##               main     #107      +/-   ##
============================================
+ Coverage     78.04%   78.06%   +0.01%     
- Complexity      440      441       +1     
============================================
  Files            64       64              
  Lines          5644     5680      +36     
  Branches        706      710       +4     
============================================
+ Hits           4405     4434      +29     
- Misses          690      693       +3     
- Partials        549      553       +4     
Impacted Files Coverage Δ
...ava/com/segment/analytics/kotlin/core/Analytics.kt 76.74% <80.76%> (+0.31%) ⬆️
...om/segment/analytics/kotlin/core/AnalyticsTests.kt 72.25% <80.95%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@wenxi-zeng wenxi-zeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. can we also have these apis in java compat?

@prayansh prayansh merged commit d5d4210 into main Sep 1, 2022
@prayansh prayansh deleted the pray/identify-traits branch September 1, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants