Allow GsonBuilder to be passed in and used through Analytics and AnalyticsClient #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pbassut - Does this make sense? Can we do this? I also wasn't sure why gsonInstance was static - not sure if I'm missing something here. |
edsonjab
reviewed
Aug 16, 2023
louislepper
force-pushed
the
customGson
branch
from
1c3f172 to
38d1e55
Compare
Done 👍 |
|
@edsonjab can we merge this branch? It's also blocking us from moving to Java 17. |
|
@bsneed / @MichaelGHSeg Would either of you be able to review? |
|
Hey @edsonjab do you have any update on this PR? 🥺 |
|
Following up internally, stay tuned. Will get an answer this week. |
wenxi-zeng
approved these changes
Sep 26, 2023
|
Hi @bsneed / @wenxi-zeng / @edsonjab Thanks for the approval. Unfortunately I don't have permission to hit merge - Would one of you be able to? |
|
Hi @louislepper we will request to merge your PR |
edsonjab
approved these changes
Sep 27, 2023
|
Released in 3.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I'm getting some issues when upgrading services to Java 17, where previously Gson was able to automatically deserialise things like java.util.Optional, and java.util.Duration, but now gets exceptions due to disallowed reflection.
Can we change Analytics / AnalyticsClient, to allow the GsonBuilder to be passed in, so that consumers can provide TypeAdapters and TypeAdapter factories as needed, for deserialisation of any classes that they'd like to send in analytics messages?