Skip to content

Conversation

@arnav777dev
Copy link
Contributor

@arnav777dev arnav777dev commented Nov 19, 2025

https://twilio-engineering.atlassian.net/browse/STRATCONN-6343

Chnged the visibility of the "Batch Data to Google Enhanced Conversions" setting so that it is no longer hidden in the UI for several related actions.
Visibility changes for batching configuration:

  • Made the batch setting visible (set unsafe_hidden: false) for the following actions:
    • uploadCallConversion
    • uploadCallConversion2
    • uploadClickConversion
    • uploadClickConversion2
    • uploadConversionAdjustment
    • uploadConversionAdjustment2

Testing

We can see the calls of batched events from integrations
image

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.95%. Comparing base (977041a) to head (701780f).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3430      +/-   ##
==========================================
+ Coverage   79.85%   79.95%   +0.09%     
==========================================
  Files        1246     1223      -23     
  Lines       23758    22691    -1067     
  Branches     4808     4503     -305     
==========================================
- Hits        18973    18143     -830     
+ Misses       3952     3717     -235     
+ Partials      833      831       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@itsarijitray itsarijitray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added the deploy:push label to the PR. Make sure to run actions-cli push once deployed.

@itsarijitray
Copy link
Contributor

cc: @joe-ayoub-segment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants