Skip to content

Conversation

@AnkitSegment
Copy link
Contributor

@AnkitSegment AnkitSegment commented Nov 17, 2025

Jira ticket: https://twilio-engineering.atlassian.net/browse/STRATCONN-6226

In this PR, I’ve added a GitHub Action check that scans for common security parameters, Failed the Github Action and raises a warning if any of those parameters are not of type password.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

⚠️ Secret Fields Detected

The following destinations require secret settings values that require review:

  • Destination: Actable Predictive
    • Settings: client_secret
  • Destination: Adjust (Actions)
    • Settings: default_app_token, default_event_token
  • Destination: Adobe Target Cloud Mode
    • Settings: client_code
  • Destination: Airship (Actions)
    • Settings: app_key
  • Destination: Clay
    • Settings: connection_key, secret_key
  • Destination: Criteo
    • Settings: api_key
  • Destination: m3ter
    • Settings: access_key_id
  • Destination: Movable Ink
    • Settings: password
  • Destination: Rehook
    • Settings: api_key, api_secret
  • Destination: Segment
    • Settings: source_write_key
  • Destination: Spiffy
    • Settings: api_key
  • Destination: Twilio
    • Settings: token
  • Destination: Usermaven (Actions)
    • Settings: api_key, server_token

This PR cannot be merged until these are removed or converted to secure secrets.

@AnkitSegment AnkitSegment marked this pull request as ready for review November 18, 2025 09:24
@AnkitSegment AnkitSegment requested a review from a team as a code owner November 18, 2025 09:24
@AnkitSegment AnkitSegment changed the base branch from staging to main November 18, 2025 09:37
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 20.45455% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.86%. Comparing base (ef1e87b) to head (fba3698).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/cli/src/commands/validate-secret-fields.ts 20.45% 35 Missing ⚠️

❌ Your patch check has failed because the patch coverage (20.45%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (31.86%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3419      +/-   ##
==========================================
- Coverage   32.57%   31.86%   -0.72%     
==========================================
  Files          14       15       +1     
  Lines         703      747      +44     
  Branches      119      126       +7     
==========================================
+ Hits          229      238       +9     
- Misses        474      509      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants