-
Notifications
You must be signed in to change notification settings - Fork 292
Added required secret check file #3419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (20.45%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3419 +/- ##
==========================================
- Coverage 32.57% 31.86% -0.72%
==========================================
Files 14 15 +1
Lines 703 747 +44
Branches 119 126 +7
==========================================
+ Hits 229 238 +9
- Misses 474 509 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jira ticket: https://twilio-engineering.atlassian.net/browse/STRATCONN-6226
In this PR, I’ve added a GitHub Action check that scans for common security parameters, Failed the Github Action and raises a warning if any of those parameters are not of type password.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'