Ortto audiences (Engage) #2927
Open
Ortto audiences (Engage) #2927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deploy:push
deploy:registration
mode:cloud
team:external
labels
joe-ayoub-segment
requested changes
Jun 6, 2025
There was a problem hiding this comment.
Hi @xitonix this looks really good!
Very few minor changes needed.
| placeholder: '180.1.12.125', | ||
| type: 'string', | ||
| format: 'ipv4', | ||
| default: { '@path': '$.context.ip' }, |
There was a problem hiding this comment.
Suggested change
| default: { '@path': '$.context.ip' }, | |
| default: '@if': { | |
| exists: { '@path': '$.traits.ip' }, | |
| then: { '@path': '$.traits.ip' }, | |
| else: { '@path': '$.properties.ip' } | |
| }, |
There was a problem hiding this comment.
The default mappings are a little different for an Engage Audience Destination.
Comment on lines
+145
to
+147
| exists: { '@path': '$.traits.address.country' }, | ||
| then: { '@path': '$.traits.address.country' }, | ||
| else: { '@path': '$.context.traits.address.country' } |
There was a problem hiding this comment.
Suggested change
| exists: { '@path': '$.traits.address.country' }, | |
| then: { '@path': '$.traits.address.country' }, | |
| else: { '@path': '$.context.traits.address.country' } | |
| exists: { '@path': '$.traits.country' }, | |
| then: { '@path': '$.traits.country' }, | |
| else: { '@path': '$.properties.country' } |
Comment on lines
+152
to
+154
| exists: { '@path': '$.traits.address.state' }, | ||
| then: { '@path': '$.traits.address.state' }, | ||
| else: { '@path': '$.context.traits.address.state' } |
There was a problem hiding this comment.
Suggested change
| exists: { '@path': '$.traits.address.state' }, | |
| then: { '@path': '$.traits.address.state' }, | |
| else: { '@path': '$.context.traits.address.state' } | |
| exists: { '@path': '$.traits.state' }, | |
| then: { '@path': '$.traits.state' }, | |
| else: { '@path': '$.properties.state' } |
Comment on lines
+159
to
+161
| exists: { '@path': '$.traits.address.city' }, | ||
| then: { '@path': '$.traits.address.city' }, | ||
| else: { '@path': '$.context.traits.address.city' } |
There was a problem hiding this comment.
Suggested change
| exists: { '@path': '$.traits.address.city' }, | |
| then: { '@path': '$.traits.address.city' }, | |
| else: { '@path': '$.context.traits.address.city' } | |
| exists: { '@path': '$.traits.city' }, | |
| then: { '@path': '$.traits.city' }, | |
| else: { '@path': '$.properties.city' } |
Comment on lines
+166
to
+168
| exists: { '@path': '$.traits.address.postal_code' }, | ||
| then: { '@path': '$.traits.address.postal_code' }, | ||
| else: { '@path': '$.context.traits.address.postal_code' } |
There was a problem hiding this comment.
Suggested change
| exists: { '@path': '$.traits.address.postal_code' }, | |
| then: { '@path': '$.traits.address.postal_code' }, | |
| else: { '@path': '$.context.traits.address.postal_code' } | |
| exists: { '@path': '$.traits.postal_code' }, | |
| then: { '@path': '$.traits.postal_code' }, | |
| else: { '@path': '$.properties.postal_code' } |
|
hi @xitonix just checking in to see if you are still interested in getting this PR over the line? If not I'll have to close it. Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @joe-ayoub-segment,
This PR is the second part of our work to support syncing Segment Audiences with Ortto. As discussed, we decided to separate it from the main analytics integration and implement it as its own integration.
When you get a chance, I'd really appreciate it if you could take a look.
Thanks,
Alex
Testing