Skip to content

STRATCONN-5948 - [Attentive] - new Ecommerce Action for Attentive #2922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

joe-ayoub-segment
Copy link
Contributor

WIP

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@joe-ayoub-segment joe-ayoub-segment changed the title [Attentive] = new Ecommerce Action for Attentive [Attentive] - new Ecommerce Action for Attentive May 15, 2025
Copy link
Contributor

github-actions bot commented May 15, 2025

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Attentive, Action Field(s):userIdentifiers,eventType,items
  • Destination: Attentive, Action Field(s):userIdentifiers,properties
  • Destination: Attentive, Action Field(s):userIdentifiers,subscriptionType,locale,signUpSourceId

Add these new fields as optional instead and assume default values in perform or performBatch block.

@joe-ayoub-segment
Copy link
Contributor Author

FYI @duynguyen100

@joe-ayoub-segment
Copy link
Contributor Author

hi @duynguyen100 just checking if this is something you still want to progress?

@joe-ayoub-segment
Copy link
Contributor Author

hi @duynguyen100 - checking in to see if you still want to progress this?

@duynguyen100
Copy link

duynguyen100 commented Jun 10, 2025 via email

@duynguyen100
Copy link

Hey @joe-ayoub-segment

I'm abit confused, are the unit tests I currently have good? Based on your video it didn't mention any unit tests and I tested it locally before you did a merge and it worked fine.

Made some changes that I haven't pushed yet, around

Custom Attributes API: properties is now required
Subscribers API:
• Added support for signUpSourceId (required if no locale)
• Enforced presence of at least one user identifier (phone or email)
• Validated subscriptionType
• Minor: externalEventId no longer expects UUID format
Tests:
• Added coverage for signUpSourceId
• Covered single identifier (phone/email only) scenarios

@joe-ayoub-segment
Copy link
Contributor Author

Hi @duynguyen100 It's been a while since I refactored your code and raised this PR.
Shall we have a call to get this done and dusted?
Here's my Calendly: https://calendly.com/joe_ayoub
I look forward to catching up,
Best regards,
Joe

@joe-ayoub-segment joe-ayoub-segment changed the title [Attentive] - new Ecommerce Action for Attentive STRATCONN-5948 - [Attentive] - new Ecommerce Action for Attentive Jun 17, 2025
@duynguyen100
Copy link

duynguyen100 commented Jun 18, 2025 via email

@joe-ayoub-segment
Copy link
Contributor Author

joe-ayoub-segment commented Jun 18, 2025 via email

@duynguyen100
Copy link

duynguyen100 commented Jun 18, 2025 via email

@joe-ayoub-segment
Copy link
Contributor Author

Hi @duynguyen100 I pushed the changes we just worked on back to this branch.

To run the testing tool locally:

./bin/run serve

To run tests locally

yarn cloud test

@joe-ayoub-segment joe-ayoub-segment mentioned this pull request Jun 18, 2025
5 tasks
@joe-ayoub-segment
Copy link
Contributor Author

hi @duynguyen100 do you need assistance to get this PR completed? Please let me know

@duynguyen100
Copy link

duynguyen100 commented Jun 23, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants