-
Notifications
You must be signed in to change notification settings - Fork 274
STRATCONN-5948 - [Attentive] - new Ecommerce Action for Attentive #2922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
New required fields detectedWarning Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production. The following required fields were added in this PR:
Add these new fields as optional instead and assume default values in |
FYI @duynguyen100 |
hi @duynguyen100 just checking if this is something you still want to progress? |
hi @duynguyen100 - checking in to see if you still want to progress this? |
Hey Joe!
Will make progress on it this week.
Best,
Duy
…On Fri, Jun 6, 2025 at 8:46 AM Joe Ayoub ***@***.***> wrote:
*joe-ayoub-segment* left a comment (segmentio/action-destinations#2922)
<#2922 (comment)>
hi @duynguyen100 <https://github.com/duynguyen100> - checking in to see
if you still want to progress this?
—
Reply to this email directly, view it on GitHub
<#2922 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNHWLUGMEJTG4S2JNGX7PB33CGESFAVCNFSM6AAAAAB5GMFLJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNBZGE3DANRTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I'm abit confused, are the unit tests I currently have good? Based on your video it didn't mention any unit tests and I tested it locally before you did a merge and it worked fine. Made some changes that I haven't pushed yet, around Custom Attributes API: properties is now required |
Hi @duynguyen100 It's been a while since I refactored your code and raised this PR. |
Hey Joe,
Let me know if right now still works, otherwise will find time for us early
next week.
Best,
Duy
…On Tue, Jun 17, 2025 at 6:47 AM Joe Ayoub ***@***.***> wrote:
*joe-ayoub-segment* left a comment (segmentio/action-destinations#2922)
<#2922 (comment)>
Hi @duynguyen100 <https://github.com/duynguyen100> It's been a while
since I refactored your code and raised this PR.
Shall we have a call to get this done and dusted?
Here's my Calendly: https://calendly.com/joe_ayoub
I look forward to catching up,
Best regards,
Joe
—
Reply to this email directly, view it on GitHub
<#2922 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNHWLUAB7LJNBVFAO5ZFQDT3D7W5TAVCNFSM6AAAAAB5GMFLJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNZZHA3TMNZWGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @duynguyen100 I pushed the changes we just worked on back to this branch. To run the testing tool locally:
To run tests locally
|
hi @duynguyen100 do you need assistance to get this PR completed? Please let me know |
Hey Joe,
Currently writing some tests and then will throw time on your calendar this
week.
Best,
Duy
…On Mon, Jun 23, 2025 at 8:26 AM Joe Ayoub ***@***.***> wrote:
*joe-ayoub-segment* left a comment (segmentio/action-destinations#2922)
<#2922 (comment)>
hi @duynguyen100 <https://github.com/duynguyen100> do you need assistance
to get this PR completed? Please let me know
—
Reply to this email directly, view it on GitHub
<#2922 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNHWLUCN2QMFNAXILBSUZYL3E7W5RAVCNFSM6AAAAAB5GMFLJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOJWGI4TQMBWGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
WIP
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.