Skip to content

Upgrade Node engine requirements to ^18.12 || ^22.13 #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sayan-das-in
Copy link
Contributor

@sayan-das-in sayan-das-in commented Feb 10, 2025

This PR introduces the following changes

  1. Upgrades Node engine requirements to ^18.12 || ^22.13
  2. Upgrades dependencies that causes issue yarn install and to fail on node 22.13
  3. Fixes build issues with PipeDrive destination that causes yarn build to fail on node 22.13
  4. Simplifies Node upgrade #2706 PR.

List of Dependency upgrades

  1. @types/node - ^18.11.15 -> ^18.11.15
  2. typescript - 4.3.5 -> 4.9.5
  3. ssh2-sftp-client - 9.1.0 -> 10.0.3

Testing

Tested locally with unit tests

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

itsarijitray
itsarijitray previously approved these changes Feb 10, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.21%. Comparing base (9c96f4c) to head (0733ebf).

Files with missing lines Patch % Lines
...nations/pipedrive/pipedriveApi/pipedrive-client.ts 16.66% 5 Missing ⚠️
...estination-actions/src/destinations/braze/utils.ts 0.00% 0 Missing and 1 partial ⚠️
...on-actions/src/destinations/pushwoosh/utilities.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2730   +/-   ##
=======================================
  Coverage   79.21%   79.21%           
=======================================
  Files        1284     1284           
  Lines       24713    24712    -1     
  Branches     5132     5125    -7     
=======================================
  Hits        19576    19576           
+ Misses       3926     3925    -1     
  Partials     1211     1211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sayan-das-in sayan-das-in force-pushed the node-engine-upgrade branch 5 times, most recently from ea23e90 to 0733ebf Compare February 13, 2025 17:17
@sayan-das-in sayan-das-in force-pushed the node-engine-upgrade branch 2 times, most recently from 220e4f1 to a7eb6a1 Compare February 25, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants