Skip to content

Increasing timeout for Google Campaign Manager 360 (https://github.com/segmentio/eks-configuration/pull/7957 follow-up) #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seg-leonelsanches
Copy link
Contributor

Increasing timeout for Google Campaign Manager 360 (https://github.com/segmentio/eks-configuration/pull/7957 follow-up)

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.50%. Comparing base (52537f3) to head (24b7644).
Report is 146 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2715      +/-   ##
==========================================
+ Coverage   78.46%   78.50%   +0.03%     
==========================================
  Files        1036     1036              
  Lines       18771    18773       +2     
  Branches     3561     3561              
==========================================
+ Hits        14729    14738       +9     
+ Misses       2844     2836       -8     
- Partials     1198     1199       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joe-ayoub-segment
Copy link
Contributor

Hi @seg-leonelsanches - just doing some tidy up here. Is this PR still something you want to progress?
If yes, then we need to find someone to review.
If not I'll close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants