Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

LAPP-57 unify analytics projects #126

Merged
merged 13 commits into from
May 13, 2020

Conversation

cgalan-applaudostudios
Copy link
Contributor

@cgalan-applaudostudios cgalan-applaudostudios commented Apr 28, 2020

This aims to simplify the structure of the projects. We obtain as benefice that we can use DotNet CLI to generate the Nuget Package. Also because the project contains all the targets, the Nuget Package is easer to create.

This will remove this warning:

[NU1701] Package 'Analytics 3.0.0' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.1'. This package may not be fully compatible with your project.

@codecov-io
Copy link

codecov-io commented Apr 28, 2020

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   85.14%   85.14%           
=======================================
  Files          26       26           
  Lines         801      801           
  Branches       80       80           
=======================================
  Hits          682      682           
  Misses        112      112           
  Partials        7        7           
Impacted Files Coverage Δ
Analytics/Flush/AsyncFlushHandler.cs 87.77% <ø> (ø)
Analytics/Flush/BlockingQueue.cs 83.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 245a9f7...b646079. Read the comment docs.

@lubird lubird closed this May 13, 2020
@lubird lubird reopened this May 13, 2020
@lubird lubird merged commit bc2fed3 into segmentio:master May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants