Skip to content

makeKey Add restriction for : #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2021
Merged

makeKey Add restriction for : #37

merged 1 commit into from
Apr 28, 2021

Conversation

prayansh
Copy link
Contributor

@prayansh prayansh commented Apr 28, 2021

as per #31, : is not allowed in firebase key names. This change adds : to the list of forbidden characters when transforming the key

Closes #31

@prayansh prayansh changed the title MakeKey Add restriction for : makeKey Add restriction for : Apr 28, 2021
@prayansh prayansh merged commit 0e66f3e into master Apr 28, 2021
@prayansh prayansh deleted the pray/fix-31 branch April 28, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EventName transformation with makeKey not proper.
2 participants