Skip to content

Fix product key mappings #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Fix product key mappings #36

merged 2 commits into from
Apr 28, 2021

Conversation

prayansh
Copy link
Contributor

@prayansh prayansh commented Apr 27, 2021

As per this (spec)[https://segment.com/docs/connections/spec/ecommerce/v2/#order-completed], we weren't mapping keys under the nested products object. These changes fixes those issues.

Screenshot to show values being mapped properly in firebase UI
Screen Shot 2021-04-27 at 5 04 39 PM

@prayansh prayansh merged commit 29f7629 into master Apr 28, 2021
@prayansh prayansh deleted the pray/fix-product-mappings branch April 28, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants