Skip to content

Bump FireBase Analytics Version #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2021
Merged

Bump FireBase Analytics Version #34

merged 3 commits into from
Mar 11, 2021

Conversation

niallzato
Copy link
Contributor

Tested after updating version, can see events arrive in the Firebase UI:
Screen Shot 2021-03-08 at 18 20 34

And all tests pass:
Screen Shot 2021-03-09 at 16 37 41

@niallzato niallzato requested a review from prayansh March 9, 2021 17:57
@prayansh
Copy link
Contributor

prayansh commented Mar 9, 2021

@niallzato i believe that there may be some deprecated events being mapped after this version upgrade, could you also include the changes to upgrade those mappings in this PR?

Copy link
Contributor

@prayansh prayansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@niallzato niallzato merged commit 81b69c9 into master Mar 11, 2021
@prayansh prayansh mentioned this pull request Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants